Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return dict not protobuf message for ffs.default_config() #38

Open
peterVG opened this issue Aug 5, 2020 · 0 comments
Open

Return dict not protobuf message for ffs.default_config() #38

peterVG opened this issue Aug 5, 2020 · 0 comments

Comments

@peterVG
Copy link
Member

peterVG commented Aug 5, 2020

Right now the user of the grpc-client has to import and use MessageToDict() from google.protobuf.json_format to convert the protobuf message to a Python dictionary. This should be abstracted away and done in the client which should just return a dictionary to the script calling ffs.default_config().

Note, this has already been done for the ffs.set_default_config() method. See

config = Parse(config, ffs_rpc_pb2.StorageConfig())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant