Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor OPTIMIZE_PAGINATION_FOR_SPEED #184

Open
dkellner opened this issue Oct 25, 2018 · 1 comment
Open

Honor OPTIMIZE_PAGINATION_FOR_SPEED #184

dkellner opened this issue Oct 25, 2018 · 1 comment

Comments

@dkellner
Copy link
Collaborator

Eve 0.7 introduced a new setting called OPTIMIZE_PAGINATION_FOR_SPEED which will skip determining the total result count of a query to improve performance.

So far we always count the rows when we execute queries (see https://github.com/pyeve/eve-sqlalchemy/blob/master/eve_sqlalchemy/structures.py#L42), we could defer that to the actual calling of count, making sure we consider all the possible arguments this is called with (e.g. https://github.com/pyeve/eve/blob/3937c126f33fa5a426af985cf4d33550a4544108/eve/methods/get.py#L236).

@Zhanweelee
Copy link

Hope this feature could be supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants