Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open multiple groups (e.g. as DataTree) with zarr-python v3 #9733

Open
TomNicholas opened this issue Nov 6, 2024 · 1 comment
Open

Open multiple groups (e.g. as DataTree) with zarr-python v3 #9733

TomNicholas opened this issue Nov 6, 2024 · 1 comment
Labels
bug topic-DataTree Related to the implementation of a DataTree class topic-zarr Related to zarr storage library upstream issue

Comments

@TomNicholas
Copy link
Member

What is your issue?

In #9552 we punted (#9552 (comment)) on making this work with zarr-python v3 because there were some upstream bugs with zarr-python v3 not correctly handling keys with slashes in them (zarr-developers/zarr-python#2357). Once that's handled properly we can ensure that the zarr backend works for open_groups and open_datatree.

cc @jhamman
@TomNicholas TomNicholas added topic-zarr Related to zarr storage library topic-DataTree Related to the implementation of a DataTree class bug labels Nov 6, 2024
@jhamman
Copy link
Member

jhamman commented Nov 10, 2024

The upstream issues are all sorted now so we should be good to go. Things may just work if we stop skipping the Datatree zarr tests for v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic-DataTree Related to the implementation of a DataTree class topic-zarr Related to zarr storage library upstream issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhamman @TomNicholas