Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypedDictValidator can drop support for extra #1522

Open
samuelcolvin opened this issue Nov 2, 2024 · 4 comments
Open

TypedDictValidator can drop support for extra #1522

samuelcolvin opened this issue Nov 2, 2024 · 4 comments

Comments

@samuelcolvin
Copy link
Member

samuelcolvin commented Nov 2, 2024

This dates back to when TypedDictValidator was used to build fields for models. extra is not supported by Python TypedDicts so we can remove the logic from here.

@sydney-runkle can we do that now, or do we need to wait for V3?

@samuelcolvin samuelcolvin changed the title TypedDictValidator can loose support for extra TypedDictValidator can drop support for extra Nov 2, 2024
@samuelcolvin
Copy link
Member Author

same might apply to dataclasses?

@sydney-runkle
Copy link
Member

Yes, I think same applies. I think we can do this in V3 :).

@Viicos
Copy link
Member

Viicos commented Nov 5, 2024

Depending on when we plan to release V3, I think it might be good to remove extra (at least for typed dicts) before, as we'll want to support PEP 728 which might get accepted soon (crossref the previous discussions we had on Slack with Sydney about this).

@sydney-runkle
Copy link
Member

Wait, thinking about this more - don't we want to leave the infrastructure for extra support given PEP 728?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants