-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove workaround for free-threaded build w. maturin #172
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #172 will improve performances by 12.1%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
=======================================
Coverage 88.74% 88.74%
=======================================
Files 13 13
Lines 2203 2203
Branches 2203 2203
=======================================
Hits 1955 1955
Misses 153 153
Partials 95 95 Continue to review full report in Codecov by Sentry.
|
cc @messense, two issues here:
EDIT: I think "failing to detect platform" is a red herring. |
I opened PyO3/maturin#2324 and PyO3/maturin#2325 to resolve. |
This reverts commit 2b67dd0.
47dd270
to
2fd43cf
Compare
xref pydantic/jiter#172 (comment) At the moment the windows builds are hard coded to use the `none` abi tag (unless they are abi3). I think this is probably technically incorrect, though in practice has worked fine historically because there was only one build on Windows... until 3.13t has come along with free-threading as a second option :) It's important that we do emit proper abi tags (e.g. `cp313`, `cp313t`) because otherwise the two 3.13 wheels end up with the same name and can't be uploaded to PyPI. I think I also saw some install failures on `jiter` CI where a Python 3.13 build ended up installing the other build's wheel (I think `pip` detected an incorrect lib name and rejected it). I suspect I might need to fix some tests...
@messense looks like there is no way to run |
Yes, but for Windows and macOS you can just |
Ok, it looks like I can deal with that separately, at least for the non-abi3 wheels I ship it seems like |
Should hopefully just work on the new maturin 1.7.5 🤞