Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[About] - Refactor: Update images on CoC to svg format #558

Open
4 tasks done
SivanYeh opened this issue Jul 19, 2024 · 0 comments
Open
4 tasks done

[About] - Refactor: Update images on CoC to svg format #558

SivanYeh opened this issue Jul 19, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@SivanYeh
Copy link
Collaborator

SivanYeh commented Jul 19, 2024

Problem

The current images imported on the Code of Conduct (CoC) page are in PNG format and become blurry when users zoom in.
Screenshot (page CoC) :
image

Screenshot (after zooming in) :
image

SVG is a better format for the web page in this context due to their advantages in file size and resolution, especially when zooming in.

Actions to Fix the Issue

  • Find the location of the code for the CoC page.
  • Go to the original design on Figma and export SVG files for each image
  • Update the images used on the CoC page from PNG files to the exported SVG files.
  • (Optional) Check if the CoC page match the suggestions for our coding convention in Issue Define Style coding convention #396.

Related Files

figma link: https://www.figma.com/design/W3hdepQ7v7ZGYRP6QctBXH/PyCon-Taiwan-%E5%AE%98%E7%B6%B2%E8%A6%96%E8%A6%BA-2022?node-id=4497-29851&t=ybffyMCnNwhJiAcZ-0

page CoC: https://tw.pycon.org/2024/en-us/about/code-of-conduct

Expected Behavior

Take the icon for “禁止騷擾” example.

Zoom in with png file imported:
image

Zoom in with updated svg file:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

2 participants