Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieval of comments missing expand parameter #949

Closed
mattmaniflaf opened this issue Jun 19, 2020 · 0 comments · Fixed by #1003
Closed

Retrieval of comments missing expand parameter #949

mattmaniflaf opened this issue Jun 19, 2020 · 0 comments · Fixed by #1003
Labels
feature Status: In progress Currently being worked on.

Comments

@mattmaniflaf
Copy link

mattmaniflaf commented Jun 19, 2020 •
edited
Loading

Retrieval of comments or an individual comment for a jira currently does not support expand parameter.

For instance if you want to retrieve the HTML renderedBody of a comment you cannot do this with jira-python, you can only do it directly via the rest api by providing the "expand=renderedBody" parameter at the end of the rest call.

Solution is quite trivial just adding expand parameter to the two client.py methods
jira/client.py : def comments()
jira/client.py : def comment()

I have a working diff, ready to go.

Version Information
Python Interpreter: 3.6
jira-python: 2.0.0
OS: Oracle Linux 7.8
@matthewkeenan matthewkeenan mentioned this issue Jul 23, 2020
Closed
matthewkeenan added a commit to matthewkeenan/jira that referenced this issue Feb 26, 2021
@matthewkeenan
Fix: pycontribs#949
9cfbd91 
Allow expands for retrieval of comments
@studioj studioj mentioned this issue May 13, 2021
Closed
@studioj studioj added feature Status: In progress Currently being worked on. labels May 13, 2021
@adehad adehad linked a pull request May 14, 2021 that will close this issue
Allow expands for retrieval of comments #1003
Merged
@ssbarnea ssbarnea mentioned this issue May 17, 2021
Merged
ssbarnea added a commit that referenced this issue May 18, 2021
@matthewkeenan @ssbarnea
Allow expands for retrieval of comments (#1003)
630973f 
* Fix: #949

Allow expands for retrieval of comments

* Move comment deletion before assert call

* Black formating

* Update tests.py

* Update comment

* Update client.py

* Update client.py

* Update client.py

* Add type and return information

* Update client.py for black style

Co-authored-by: Sorin Sbarnea <[email protected]>
svermeulen pushed a commit to svermeulen/jira that referenced this issue Oct 31, 2021
@matthewkeenan @ssbarnea @svermeulen
Allow expands for retrieval of comments (pycontribs#1003)
6ddd16b 
* Fix: pycontribs#949

Allow expands for retrieval of comments

* Move comment deletion before assert call

* Black formating

* Update tests.py

* Update comment

* Update client.py

* Update client.py

* Update client.py

* Add type and return information

* Update client.py for black style

Co-authored-by: Sorin Sbarnea <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Status: In progress Currently being worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow expands for retrieval of comments matthewkeenan/jira
2 participants
@mattmaniflaf @studioj