Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review for timing attacks #11

Open
3 tasks
alex opened this issue Oct 5, 2013 · 2 comments
Open
3 tasks

Review for timing attacks #11

alex opened this issue Oct 5, 2013 · 2 comments

Comments

@alex
Copy link
Member

alex commented Oct 5, 2013

My understanding is that we're concerned that any function over the secret-key (or something derived from it), must take time independent of the input value. Here are possible issues I see

  • scalarmult takes time in e, and in publickey() e is a function of sk, not sure if this is a concern (it's a function of the magnitude of e, which may not correlate with an individual value)
  • In encodepoint (as called from publickey()), y >> i is probably not timing independent, it's time is a function of the magnitude of y.
  • In publickey and signature 2 ** i * bit(h, i) takes time in the magnitude of the bit from h (h is computed from the sha256 of sk, so perhaps it can't be reversed?)

Those are what I have for now, more review is definitely needed.

@Ivoz
Copy link

Ivoz commented Oct 6, 2013

Hopefully the third might be solved by #17

The second would include both encodepoint and encodeint

@gnprice
Copy link
Contributor

gnprice commented Nov 2, 2013

This should be closeable after #19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants