-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified project repo's with all-repos #3
Comments
I do not think that this makes sense in the short term: The projects tend to be different enough (for now) and I do not really see the need to do cross-project adjustments for now. As it stands, we have fpdf2 with setuptools, pypdf (and pdfly) with flit and pypdf_table_extraction with poetry. While there might be shared resources/experience, I would argue that this rather is about factual than distribution-specific stuff. Enforcing specific rules or build pipelines is already represented by corresponding GitHub workflows - I personally tend to have a look at the contribution guide for specific rules and then just let CI tell me what might need further adjustments. |
I agree, Ideally we would utilize the same toolset within al repo's. On the other hand, it is good to get started here and have some mechanisims in place. |
@bosd I used the cookiecutter-hypermodern-python to scaffold the previous fork and merged back in the source.
The docs contain some tutorials: https://cookiecutter-hypermodern-python.readthedocs.io/en/2022.6.3.post1/guide.html#tutorials |
@foarsitter Yes, the hypermodern-cookiecutter. The cookiecutter project you're referring too, IMO still seems the best of the bunch. We can stull use it as a base. Merge the improvements which are worthwhile from one of the forks here. |
I would propose that we unify all the repositories under the py-pdf organization with all-repos. I would like to see that within the py-pdf organization projects the same tools and configurations are used where possible so the possibility arises to make adjustments cross-repo with
all-repos
.This gives us the benefits that all the maintainers now how to run the tests and do some maintenance tasks like updating a python version and extending the test-matrix because they are familiar with the project structure without knowing the code.
The text was updated successfully, but these errors were encountered: