Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge open PRs into pypdf_table_extraction #1

Open
MartinThoma opened this issue Feb 25, 2024 · 6 comments
Open

Merge open PRs into pypdf_table_extraction #1

MartinThoma opened this issue Feb 25, 2024 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@MartinThoma
Copy link
Member

MartinThoma commented Feb 25, 2024

Before we do all of the renamings, we should make sure that we take the big changes.

camelot-dev#353 was merged and should be part of this codebase already. There are others, though: https://github.com/camelot-dev/camelot/pulls

@MartinThoma MartinThoma added bug Something isn't working and removed bug Something isn't working labels Feb 25, 2024
@MartinThoma
Copy link
Member Author

https://pypi.org/project/pypdf-table-extraction/ was published as a complete fork. It's what is currently on camelot-dev/camelot#master

@MartinThoma MartinThoma changed the title Fully Migrate to pypdf_table_extraction Merge open PRs into pypdf_table_extraction Feb 25, 2024
@snanda85
Copy link

@MartinThoma @foarsitter Is there any movement planned on this project now?

Looks like there are a few PRs waiting to be merged in this repo.

How can we help? Is there a priority order for items that the community can pick.

@foarsitter
Copy link
Collaborator

@snanda85 Not a lot of movement. There are some important decisions to be made but not much debate is arising from the community.

@bosd
Copy link
Collaborator

bosd commented Aug 11, 2024

Have you seen this (old) and huge PR, introducing 2 new parsers?
camelot-dev#153
Is it worhwhile looking into and merge it here?

@bosd
Copy link
Collaborator

bosd commented Aug 11, 2024

This one might be interesting as well.
Have'nt checked the acclaimed speed improvement.
camelot-dev#89

@bosd
Copy link
Collaborator

bosd commented Aug 12, 2024

How can we help?

@snanda85 You can help by reviewing PR's.
Open new PR's.
There are some places where coverage can be increased. Or perferomance optimized.
There are also 2 bigger PR's in the old repo to consider (see my previous 2 comments)

Is there a priority order for items that the community can pick.

Idk, my best guess for a sequence is:

Feel free to add/update this list

There are some important decisions to be made but not much debate is arising from the community.

@foarsitter Which decisions are you refering to? There is not a lot of movement here (yet..)
So maybe EAFP and move forward?

@bosd bosd added the help wanted Extra attention is needed label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants