Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠️ Adapt to actions/upload-artifact action to v4 #324

Closed
wants to merge 3 commits into from
Closed

🛠️ Adapt to actions/upload-artifact action to v4 #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37134de
Update actions/upload-artifact action to v4
renovate[bot] Dec 14, 2023
aa66d91
📝 Replace `artifact@v3` to `artifact@v4` in `README.md`
keunhyung-chung Dec 22, 2023
99f1739
⚒️ Use `pattern` and `merge-multiple` input in `download-artifact@v4`
keunhyung-chung Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
ANNOTATE_MISSING_LINES: true

- name: Store Pull Request comment to be posted
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: steps.coverage_comment.outputs.COMMENT_FILE_WRITTEN == 'true'
with:
name: python-coverage-comment-action
Expand Down
15 changes: 8 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ jobs:
GITHUB_TOKEN: ${{ github.token }}

- name: Store Pull Request comment to be posted
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: steps.coverage_comment.outputs.COMMENT_FILE_WRITTEN == 'true'
with:
# If you use a different name, update COMMENT_ARTIFACT_NAME accordingly
Expand Down Expand Up @@ -252,9 +252,9 @@ jobs:
# directly or through PYTEST_ADD_OPTS.

- name: Store coverage file
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: coverage
name: coverage-${{ matrix.python_version }}
path: .coverage.${{ matrix.python_version }}

coverage:
Expand All @@ -267,10 +267,11 @@ jobs:
steps:
- uses: actions/checkout@v4

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
id: download
with:
name: "coverage"
pattern: coverage-*
merge-multiple: true

- name: Coverage comment
id: coverage_comment
Expand All @@ -280,7 +281,7 @@ jobs:
MERGE_COVERAGE_FILES: true

- name: Store Pull Request comment to be posted
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: steps.coverage_comment.outputs.COMMENT_FILE_WRITTEN == 'true'
with:
name: python-coverage-comment-action
Expand Down Expand Up @@ -454,7 +455,7 @@ jobs:
GITHUB_TOKEN: ${{ github.token }}

- name: Store Pull Request comment to be posted
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: steps.coverage_comment_1.outputs.COMMENT_FILE_WRITTEN == 'true' || steps.coverage_comment_2.outputs.COMMENT_FILE_WRITTEN == 'true'
with:
name: python-coverage-comment-action
Expand Down
2 changes: 1 addition & 1 deletion tests/end_to_end/repo/.github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
SUBPROJECT_ID: __ACTION_SUBPROJECT_ID__

- name: Store Pull Request comment to be posted
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: steps.coverage_comment.outputs.COMMENT_FILE_WRITTEN == 'true'
with:
name: python-coverage-comment-action
Expand Down
Loading