🛠️ Adapt to actions/upload-artifact action to v4

[keunhyung-chung]

⭐ What does this PR do?

• Fixes upload-artefact@v4 is incompatible with our advertised way of handling multiple python versions #316

🚀 What I've done

• Update the README with the instructions

[github-actions]

End-to-end public repo

[github-actions]

Coverage report

Note

Coverage evolution disabled because this PR targets a different branch
than the default branch, for which coverage data is not available.

The coverage rate is 100%.
The branch rate is 100%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

[ewjoachim]

/e2e

[ewjoachim]

damn it, there's a bug in our own workflow (oh the irony) keeping us from running end to end tests on your code :( I'll need to solve that.

[ewjoachim]

/e2e

[ewjoachim]

/e2e
(it's going to work in the end 🤞 )

[ewjoachim]

/e2e

/whistle 😗 🎵
Everything's fine !

[ewjoachim]

That's quite messed up. I trigger a workflow when I review this PR. I can't run the e2e tests in that workflow (for permission reasons. This workflow is linked to your fork and has limited rights. So far so good.). When that workflow ends, it triggers a second workflow. The second workflow is able to run the e2e tests, but it needs to know the PR number.
The 2nd workflow has access to the workflow_run event describing the 1st workflow and to the whole github API. Yet, for the life of me, I can't link the 1st workflow to this PR.

Because this PR and #314 share the same branch name, it seems GitHub is convinced that the workflow belongs to PR 314...

[keunhyung-chung]

That's quite messed up. I trigger a workflow when I review this PR. I can't run the e2e tests in that workflow (for permission reasons. This workflow is linked to your fork and has limited rights. So far so good.). When that workflow ends, it triggers a second workflow. The second workflow is able to run the e2e tests, but it needs to know the PR number. The 2nd workflow has access to the workflow_run event describing the 1st workflow and to the whole github API. Yet, for the life of me, I can't link the 1st workflow to this PR.

Because this PR and #314 share the same branch name, it seems GitHub is convinced that the workflow belongs to PR 314...

@ewjoachim Thanks for the detailed explanation 👍. Is there any thing to do from my side?

[ewjoachim]

Don't mind me.

[ewjoachim]

/e2e

[ewjoachim]

@ewjoachim Thanks for the detailed explanation 👍. Is there any thing to do from my side?

Haha, sorry. I'll just take your commits, put them in a differently-named branch, create a new PR and it "should" work.

Sorry for all the noise 😅

[ewjoachim]

Closed by #326

[ewjoachim]

Released: https://github.com/py-cov-action/python-coverage-comment-action/releases/tag/v3.16

Thank you ! <3
It was a pleasure receiving your contribution, and I'm sorry again that our internal tooling made things complicated. Feel free to contribute again someday (hopefully our CI will be 100% working by then)