You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have no way to test such a change, I don't have access to an deploy of GH enterprise. I'll be happy to merge a PR you'd provide if you can validate on your side that it works, but I'm not sure if I can be in a position to ensure that it doesn't break in the future, so it will likely not be official support, but best effort. If that's ok with you, then feel free to submit a PR, I'll gladly merge it. (or maybe someone else interested by the change would like to implement it)
As an enterprise user i want to have the API url not hardcoded so i can use this action in a different environment.
Problem: Action cannot be used in a enterprise install
Cause: Hardcoded URL's
Containment: None
Solution: Use default github environment variables
https://docs.github.com/en/codespaces/developing-in-a-codespace/default-environment-variables-for-your-codespace
GITHUB_SERVER_URL
GITHUB_API_URL
Example:
https://github.com/py-cov-action/python-coverage-comment-action/blob/main/coverage_comment/main.py
Proposed:
github_session = httpx.Client(
base_url="{config.GITHUB_API_URL}",
follow_redirects=True,
headers={"Authorization": f"token {config.GITHUB_TOKEN}"},
)
Please investigate for more hardcoded URLs
The text was updated successfully, but these errors were encountered: