Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNG badges in coverage comment #414

Closed
wants to merge 1 commit into from
Closed

PNG badges in coverage comment #414

wants to merge 1 commit into from

Conversation

ewjoachim
Copy link
Member

Closes #371

Copy link

End-to-end public repo

Admin commands cheatsheet:

  • /e2e (in approved PR review body): Trigger end-to-end tests on external contributions
  • /invite (in comment): Invite the author & admins to the end-to-end private repo

@ewjoachim
Copy link
Member Author

ewjoachim commented May 26, 2024

Screenshot 2024-05-26 at 10 11 41

The good news is that the images appear in the gmail notification.
The bad news is that it's a pixel garbage mess, barely readable (on a retina display).

@ewjoachim
Copy link
Member Author

Of course, the github version is a mess too
Screenshot 2024-05-26 at 10 14 55

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  coverage_comment
  badge.py
  template.py
Project Total  

This report was generated by python-coverage-comment-action

@ewjoachim ewjoachim closed this May 27, 2024
@ewjoachim ewjoachim reopened this May 27, 2024
@ewjoachim
Copy link
Member Author

Here's the comment that was posted:

Coverage report (my-great-project)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  subdir/end_to_end_tests_repo
  __init__.py
Project Total  

This report was generated by python-coverage-comment-action

@ewjoachim
Copy link
Member Author

ewjoachim commented May 27, 2024

<img src="https://img.shields.io/badge/Coverage%20evolution-83%25%20%3E%2091%25-brightgreen.png">

This would be with srtset 2x:

<img srcset="https://img.shields.io/badge/Coverage%20evolution-83%25%20%3E%2091%25-brightgreen.png 2x" src="https://img.shields.io/badge/Coverage%20evolution-83%25%20%3E%2091%25-brightgreen.png">

(it doesn't display)

@ewjoachim
Copy link
Member Author

@ewjoachim
Copy link
Member Author

ewjoachim commented May 27, 2024

<picture>
  <source media="(min-resolution: 2dppx)" srcset="https://webkit.org/demos/srcset/image-2x.png">
  <img src="https://webkit.org/demos/srcset/image-1x.png">
</picture>

Doesn't work for me: the image loads when I open the PR, but when I reload, it disappears.

@ewjoachim
Copy link
Member Author

Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images don't display in email notifications from Gmail
1 participant