Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Craft mail setting changed Campaign settings #353

Closed
philipboomy opened this issue Dec 18, 2022 · 7 comments
Closed

Craft mail setting changed Campaign settings #353

philipboomy opened this issue Dec 18, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@philipboomy
Copy link

First off I am not 100% if this happened because of this but I am fairly certain it did.

I had to change to AWS for Craft due to Postmarkapp was having issues. Luckily I had your AWE SES plugin installed as I am using it for Campaign.

  1. Locally I changed my Craft email settings to AWS SES and pushed my project config up to server.
  2. After postmark fixed their issue I changed Craft local email settings back to SMTP and pushed project config up to server.
  3. Today I noticed that Campaign sent emails using postmark SMTP and when I checked locally what Campaign email settings were it was SMTP but I never changed those.

I believe when I changed from AWS to STMP in Craft email settings it changed Campaign. Not sure if this has anything to do with this issue #321

Amazon SES 2.0.1
Campaign 2.3.1
Craft Pro 4.3.5

@philipboomy philipboomy added the bug Something isn't working label Dec 18, 2022
@bencroker
Copy link
Collaborator

bencroker commented Dec 19, 2022

Assuming this is all going through project config, shouldn't you be able to track down when what was changed in the git commit history?

Not sure if this has anything to do with this issue #321

This is only a feature request, so no.

@philipboomy
Copy link
Author

Looking at the commits it looks like Craft Campaign changed the settings and not me.

manually-changed-campaign
changed-craft-back
changed-craft

@bencroker
Copy link
Collaborator

bencroker commented Dec 19, 2022

So are you saying that the second screenshot above was a change that the Campaign plugin made on its own? I don't see anything in the code that could do that. What are the timings of those changes?

@philipboomy
Copy link
Author

These screenshots shows what the changes were in project config and as you can see there was not a time where I pushed up a change to Campaign settings.

@bencroker
Copy link
Collaborator

bencroker commented Dec 23, 2022

as you can see there was not a time where I pushed up a change to Campaign settings.

How can I see that exactly? I'm not seeing any commit messages so don't know when or by whom these changes were made.

@philipboomy
Copy link
Author

What do you want exactly?

@philipboomy
Copy link
Author

I tried to replicate and I can't. So will close. Hopefully a user error. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants