Merging react-native-network-info with react-native-netinfo

[Rapsssito]

As commented here: react-native-netinfo/react-native-netinfo#52 (comment) by @mikehardy, these two libraries seem like an API surface area duplication and potential to perhaps have multiple active maintainers in one repo?

Is there any possibility of merging both repositories, @pusherman and @matt-oakes, into one so we get the best of them?

[matt-oakes]

👋 I would be really happy to merge these two libraries together.

@pusherman Let me know if you would also be happy to collaborate and we can talk about how this would work in practice.

[hosseinmd]

awsome merge
I would like to help you too

[Rapsssito]

Yeah, me too!

[hosseinmd]

@matt-oakes please begin and tell us what to do

[pusherman]

Hey @matt-oakes, I think merging the two may make sense. I'll shoot you an email using the email address from your website. We can update this thread once we have a plan.

[Rapsssito]

@pusherman or @matt-oakes any news?

[matt-oakes]

@pusherman I’ve not heard from you yet. Feel free to get in touch if you’re still interested in this

[pusherman]

Hey @matt-oakes I sent an email to the email on your website ([email protected]) on Oct 1st. I'll resent it now. Let me know if you don't get it or if there's a better email address to reach you at.

[Rapsssito]

@pusherman or @matt-oakes, any news?

[pusherman]

@Rapsssito - I did talk with @matt-oakes about this. The plan is to open up a PR on the react-native-netinfo side that merges in the functionality from this library. I have not had time to get started on it yet but if anyone else here wants to give it a go-- that's the direction we will head.

[Rapsssito]

@pusherman, glad to hear that! Could you open an issue over react-native-netinfo with a TODO and refer to this issue?

I will close this issue once that issue is created.

[ependergrass]

This would be a great help! We recently tried to implement react-native-network-info to try to get default gateway address but had to retreat to react-native-netinfo after running into some issues. Would be wonderful to have the best of both worlds!