Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: structurised images in svg folder #584

Closed
wants to merge 1 commit into from
Closed

chore: structurised images in svg folder #584

wants to merge 1 commit into from

Conversation

ameeetgaikwad
Copy link
Contributor

fixes #486

@vercel Vercel
Copy link

vercel bot commented Jan 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
push-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 7:55pm

@ameeetgaikwad ameeetgaikwad mentioned this pull request Jan 12, 2024
Open
@ameeetgaikwad ameeetgaikwad changed the title chore: structurised images in svg folder chore: structurised images in svg folder [WIP - Do not merge YET] Jan 14, 2024
@ameeetgaikwad ameeetgaikwad marked this pull request as draft January 14, 2024 14:28
@ameeetgaikwad ameeetgaikwad changed the title chore: structurised images in svg folder [WIP - Do not merge YET] chore: structurised images in svg folder Jan 14, 2024
@HarshRajat
Copy link
Contributor

Hey @ameeetgaikwad,

This is a good start though we need the structure to be aligned to what the assets are going to be used for as well. For example:

  • All assets that are not used in blog or docs should go in assets/website
  • In the website folder, each subfolder is the subsequent page where the images referenced from there should be stored
  • In this case, the svgs if they are referenced in the website should be moved to assets/website/brb/community and the relevant link should be updated.
  • Though since the svgs you are moving are already not used, they should simply be deleted.

Hope that clears things up.

@ameeetgaikwad
Copy link
Contributor Author

ameeetgaikwad commented Jan 17, 2024 •
edited
Loading

@HarshRajat the images in the static/assets/website/frens-list folder, should I put all these images in the static/assets/website/frens folder?

@HarshRajat
Copy link
Contributor

closing as the issue has turned stale, feel free to open a fresh one.

@HarshRajat HarshRajat closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup images in folder structure
2 participants
@ameeetgaikwad @HarshRajat