Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

😈 [Feature Enhancement] - <modify onlyActivatedChannels() to include onlyChannelOwner check - Remove onlyChannelOwner func> #288

Closed
zaryab2000 opened this issue Feb 9, 2024 · 0 comments
Assignees
Labels
priority-2 Medium priority
Milestone

Comments

@zaryab2000
Copy link
Collaborator

Feature name

The core contract includes an onlyChannelOwner internal function as of now , which is only used in updateChannelMeta() function and nowhere else.

Describe the Enhancement

The desired behaviour would be to remove lesser used internal function.

Therefore a better design would be to:

  • Modify onlyActivatedChannels internal function to also include the logic of only-channel-owner check
  • Remove onlyChannelOwner() completely
  • Update updateChannelMeta function to use the newly updated onlyActivatedChannels

POC if available

No response

Contract Name

Core Contract

@zaryab2000 zaryab2000 added the priority-2 Medium priority label Feb 9, 2024
@zaryab2000 zaryab2000 assigned Zartaj0 and unassigned Zartaj0 Feb 14, 2024
@zaryab2000 zaryab2000 removed their assignment Mar 15, 2024
@zaryab2000 zaryab2000 assigned zaryab2000 and unassigned Zartaj0 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-2 Medium priority
Projects
None yet
Development

No branches or pull requests

2 participants