Don't highlight top-level-only keywords at different levels #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi-Angel
force-pushed
the
dont-highlight-toplevel-only-keywords
branch
3 times, most recently
from
719d4e2
to
ab85b8d
Compare
|
upd: added |
The keywords being modified here only represented keywords when they
are at the beginning of a line with optional indentation.
At different levels these would represent valid record fields or other
identifiers.
This was tested by adding the following code to a PureScript file:
type Foo = { type :: Int
, module :: Int
, import :: Int
, data :: Int
, class :: Int
, newtype :: Int
}
…and checking that compilation succeeds.
Hi-Angel
force-pushed
the
dont-highlight-toplevel-only-keywords
branch
from
ab85b8d
to
ba3e997
Compare
|
@kritzcreek , ping? |
|
ping |
1 similar comment
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keywords being modified here only represented keywords when they are at the beginning of a line with optional whitespace.
At different levels these would represent valid record fields or other identifiers.
This was tested by adding the following code to a PureScript file:
…and checking that compilation succeeds.