Skip to content
This repository has been archived by the owner on Oct 4, 2020. It is now read-only.

FoldableWithIndex instance leaking structure #138

Open
matthewleon opened this issue Jan 17, 2018 · 1 comment
Open

FoldableWithIndex instance leaking structure #138

matthewleon opened this issue Jan 17, 2018 · 1 comment

Comments

@matthewleon
Copy link
Contributor

matthewleon commented Jan 17, 2018

Several others:

All FoldableWithIndex folds are leaking structure, as they use toUnfoldable. The cases of foldlWithIndex and foldMapWithIndex are addressed by #137

This leaves foldrWithIndex. It should probably be switched to use toAscUnfoldable, or solved more creatively.

@matthewleon
Copy link
Contributor Author

I edited the above to remove some of the functions that I thought were leaking structure... Though they used an inefficient strategy for building their output, it was still ordered.

@matthewleon matthewleon changed the title other functions that leak structure FoldableWithIndex instance leaking structure Jan 18, 2018
matthewleon added a commit to matthewleon/purescript-maps that referenced this issue Jan 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant