Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Strict Reference mode #39

Open
tuukkamustonen opened this issue Oct 24, 2019 · 3 comments
Open

Support Strict Reference mode #39

tuukkamustonen opened this issue Oct 24, 2019 · 3 comments

Comments

@tuukkamustonen
Copy link

tuukkamustonen commented Oct 24, 2019

Looks like Strict Reference mode is not supported, correct?

@tuukkamustonen tuukkamustonen changed the title Support strict mode Support Strict Reference mode Oct 24, 2019
@tuukkamustonen
Copy link
Author

I think https://github.com/purcell/airspeed/blob/master/airspeed/__init__.py#L607 would be the place to add it?

@purcell
Copy link
Owner

purcell commented Oct 25, 2019

No, it's not supported, and yes, I think that would be the right place to make a change. It's not clear where we'd set and store a value indicating whether strict mode is enabled. We don't really have anything analogous to velocity's config vars at this stage.

@tuukkamustonen
Copy link
Author

tuukkamustonen commented Oct 25, 2019

I'll take a closer look at the code and try to hack in something (not sure if we absolutely need this feature, so there are conditionals). If I manage to produce something working, I'll send a PR.

Maybe the loader could store some config map? It's already passed around a lot. Though, semantically it's the wrong place to put configs (as it's only for #include and #parse), but it's force-initialized so could work as a vessel to carry out the configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants