Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgis: Drop EL5 leftovers and fix package name for Fedora #1521

Merged
merged 2 commits into from
Sep 27, 2023
Merged

postgis: Drop EL5 leftovers and fix package name for Fedora #1521

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54b503d
postgis: Drop EL5 leftovers
bastelfreak Sep 27, 2023
02b5ebe
postgis: fix package name for Fedora
bastelfreak Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/params.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@

if $postgresql::globals::postgis_package_name {
$postgis_package_name = $postgresql::globals::postgis_package_name
} elsif $facts['os']['release']['major'] == '5' {
bastelfreak marked this conversation as resolved.
Show resolved Hide resolved
} elsif $facts['os']['name'] == 'Fedora' {
$postgis_package_name = 'postgis'
} elsif $postgis_version and versioncmp($postgis_version, '2') < 0 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I noted elsewhere: in EL 8 & EL 9 I didn't find a postgis package. For the official packages I see there's postgis32 and postgis33 (https://download.postgresql.org/pub/repos/yum/15/redhat/rhel-9-x86_64/) so the else condition isn't quite true either.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure how we should move forward. It seems like there are no acceptance tests for this code and I don't know on which systems they work / are supposed to work. My goal was to simplify the conditions here and clean it up. I can raise a ticket about the mismatch.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raised #1522

$postgis_package_name = "postgis${package_version}"
Expand Down
Loading