postgis: Drop EL5 leftovers and fix package name for Fedora #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
requested review from
alexjfisher,
deric,
ekohl,
SimonHoenscheid,
smortex and
a team
as code owners
SimonHoenscheid
previously approved these changes
Sep 27, 2023
ekohl
reviewed
Sep 27, 2023
| @@ -99,8 +99,6 @@ | |||
|
|
|||
| if $postgresql::globals::postgis_package_name { | |||
| $postgis_package_name = $postgresql::globals::postgis_package_name | |||
| } elsif $facts['os']['release']['major'] == '5' { | |||
| $postgis_package_name = 'postgis' | |||
| } elsif $postgis_version and versioncmp($postgis_version, '2') < 0 { | |||
There was a problem hiding this comment.
As I noted elsewhere: in EL 8 & EL 9 I didn't find a postgis package. For the official packages I see there's postgis32 and postgis33 (https://download.postgresql.org/pub/repos/yum/15/redhat/rhel-9-x86_64/) so the else condition isn't quite true either.
There was a problem hiding this comment.
I'm not really sure how we should move forward. It seems like there are no acceptance tests for this code and I don't know on which systems they work / are supposed to work. My goal was to simplify the conditions here and clean it up. I can raise a ticket about the mismatch.
bastelfreak
changed the title
bastelfreak
force-pushed
the
postgis
branch
from
6b4a0a0
to
02b5ebe
Compare
ekohl
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)