-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow management of arbitrary files like modulesync does #115
Comments
The specific use cases I have are:
Sent with GitHawk |
+1 we need this too |
When we set out to build the pdk-templates, the thought was that folks with additional needs like this will fork pdk-templates, add their additionally required files and defaults, and regularly pull in from pdk-templates#master (or whatever tag matching their PDK version they're running). Would this work for you? |
IMO, no. I don't want to add work to my plate by having to manually track changes in pdk-templates. My goal is not to diverge from the templates provided by Puppet but rather supplement them. In the scenario described in this issue I would not have to spend cycles tracking upstream changes, I'd just have to keep my site-specific data up-to-date. Generally speaking, the PDK and its associated templates are updated much more often than my site-specific data / configs / files. |
@DavidS This is something I basically discussed back in 2018 with @bmjen and the preference I believe would be to allow for a similar so for example you could set in the config_defaults.yml that in spec/spec_helper.rb you wanted minimum_coverage of 95 but there is one module you know won't meet that so you'd either nil it in that single modules So its' like pdk-templates has it's defaults... the pdksync has defaults override those... and then the module has .sync.yml to be the final override. |
The overwhelming desire for this has resurfaced for me too as I have started another round of work on modules |
I was also wanting this. Ended up putting this in my CI file. This will find all directories and put files using cp or rsync
or
|
PDKSync should allow for this as it is a function of modulesync that I no longer have access to due to the PDK also using a file names
.sync.yaml
for its configuration.I use this functionality to maintain a templetized version of files not edited by the PDK.
Sent with GitHawk
The text was updated successfully, but these errors were encountered: