Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to block facts/factsets with regexp or some subgroup/wildcard. #2713

Closed
sharewax opened this issue May 7, 2024 · 4 comments
Labels
enhancement New feature or enhancement

Comments

@sharewax
Copy link

sharewax commented May 7, 2024

Use Case

Currently I observe that a lot of facts/factsets pushed in puppetdb which is not needed. For example I don't need info about virtual interfaces on host, like cali, docker, veth and etc. Currently I can block only all interfaces in blocklist like "networking.interfaces" but not "networking.interfaces.cali.*", "networking.interfaces.veth.*", "networking.interfaces.docker.*", "networking.interfaces.macvtap.*", "networking.interfaces.vnet.*", "networking.interfaces.tunl.*".
Also it's impossible to block on puppetdb level because of new structure with hashes instead of flat sctructure.
Also block doesn't work for 3rd level of hierarchy like "networking.interfaces.docker0" doesn't block this fact, only whole "networking.interfaces" works.

Describe the Solution You Would Like

I would like to store less facts in puppetdb and/or output in facter output. It would be perfect if we can block facts/facts block by wildcard/regexp (like in puppetdb with facts-blocklist-type = regex).

@sharewax sharewax added the enhancement New feature or enhancement label May 7, 2024
@joshcooper
Copy link
Contributor

@sharewax we have an issue filed to allow portions of structured fact values to be filtered in #2658 I think that would solve your use case.

it's impossible to block on puppetdb level because of new structure with hashes instead of flat sctructure.

This sounds like a bug in puppetdb. I would expect it's possible to block structured facts to limit the amount of data stored there, especially since legacy facts are disabled by default in Puppet 8. Maybe the facts-blocklist-type setting has never worked with structured facts?

Based on that I'm thinking we should close this as a dup of 2658 and file a separate issue for puppetdb. Thoughts?

@sharewax
Copy link
Author

sharewax commented May 7, 2024

Yes, the #2658 is looks as the same here.
I've created ticket in puppetdb space, thank you. Maybe you can extend more info in this ticket.

@joshcooper
Copy link
Contributor

Thanks for adding the puppetdb ticket, I'm going to close this as a dup of #2658

Maybe you can extend more info in this ticket.

I didn't quite get this part? Could you add any details that you think are missing from this ticket to 2658?

@joshcooper joshcooper closed this as not planned Won't fix, can't repro, duplicate, stale Jun 6, 2024
@sharewax
Copy link
Author

sharewax commented Jun 6, 2024

all is ok, maybe I just think that info (like in #2658) for puppetdb will be also useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants