The cloud.provider fact still calls EC2 despite EC2 being in the block list

[tvpartytonight]

Describe the Bug

Even if EC2 is in the blocklist for facter, the cloud.provider fact will still make a call to EC2. The spot where it calls EC2 is here.

Expected Behavior

When EC2 is in the blocklist for facts, no calls should be made to EC2.

Workaround

Add the cloud.provider fact in the blocklist as well as EC2 to prevent the call.

Additional Context

Is related to #2672

• The block list groups are defined in

  facter/lib/facter/config.rb

  Lines 65 to 68 in fabedea

  	'EC2' => %w[
  	ec2_metadata
  	ec2_userdata
  	],

• We probably need to add the cloud.provider fact to both the EC2 and GCE fact groups. Or perhaps we need to block the entire cloud fact, similar to how the operating system group blocks the entire os fact.
• We're missing an AWS fact group.