Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to okhttp3 #46

Open
azell opened this issue Jan 30, 2016 · 5 comments
Open

Upgrade to okhttp3 #46

azell opened this issue Jan 30, 2016 · 5 comments
Assignees
@circlespainter
Labels
enhancement

Comments

@azell
Copy link
Contributor

azell commented Jan 30, 2016

Latest release is 3.0.1 which uses different package name (okhttp3.OkHttpClient, etc.). Is this blocked due to OkHttpClient being final in 3.0.1?

That should be fixed in square/okhttp#2292.
@circlespainter circlespainter self-assigned this Jan 31, 2016
@circlespainter
Copy link
Member

That certainly doesn't help, it'll be easier when it's fixed.

@azell
Copy link
Contributor Author

azell commented Feb 1, 2016

Is there any technical reason not to support Comsat Retrofit with OkHttp as the underlying client in addition to Apache?

@circlespainter
Copy link
Member

Not that I'm aware of, indeed that's something worth looking into.

@circlespainter
Copy link
Member

Would you mind creating a feature request issue about that too?

@jonathannaguin
Copy link

OkHttpClient is no longer "final", at least in the latest version, is this something we can have upgraded?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@circlespainter circlespainter

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonathannaguin @azell @circlespainter