Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scripts/install-pulumi-plugin.js and upgrade Pulumi #102

Closed
t0yv0 opened this issue Sep 12, 2023 · 0 comments · Fixed by #106
Closed

Remove scripts/install-pulumi-plugin.js and upgrade Pulumi #102

t0yv0 opened this issue Sep 12, 2023 · 0 comments · Fixed by #106
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@t0yv0
Copy link
Member

t0yv0 commented Sep 12, 2023

What happened?

For both native and bridged providers upgrading past
https://github.com/pulumi/pulumi/releases/tag/v3.80.0 introduces an important change (for bridged
providers this starting with
https://github.com/pulumi/pulumi-terraform-bridge/releases/tag/v3.59.0). The change is fully
described in pulumi/pulumi#13800 and affects how Node and Python packages
are generated.
Prior to the change, installing the Node or Python version of a bridged provider via npm or pip
would run a script that ensures that the provider binary itself is installed. After the change, that
is no longer the case, and Pulumi CLI takes over the responsibility for automatic installation.
In practice you may observe files disappearing upon upgrade, for example these files will be removed
from Pulumi bridged providers:
https://github.com/pulumi/pulumi-aws-apigateway/blob/main/sdk/nodejs/scripts/install-pulumi-plugin.js
https://github.com/pulumi/pulumi-azure-native/blob/master/sdk/nodejs/scripts/install-pulumi-plugin.js
If your project is using Makefile targets that deal with these scripts, these require a small
update. For example, in pulumi-azure-native we need to remove the following line from the Makefile:
mkdir -p bin/scripts && cp scripts/install-pulumi-plugin.js bin/scripts
And in pulumi-aws-apigateway this line is removed:
cp -R scripts/ bin &&
https://github.com/pulumi/pulumi-aws-apigateway/pull/85/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L74

Expected Behavior

Works after upgrade

Steps to reproduce

N/A

Output of pulumi about

N/A

Additional context

N/A

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@t0yv0 t0yv0 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Sep 12, 2023
@iwahbe iwahbe removed the needs-triage Needs attention from the triage team label Dec 26, 2023
@iwahbe iwahbe pinned this issue Jan 2, 2024
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants