Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize cancellation semantics #29

Open
lblackstone opened this issue Jun 2, 2022 · 0 comments
Open

Standardize cancellation semantics #29

lblackstone opened this issue Jun 2, 2022 · 0 comments
Labels
kind/enhancement Improvements or new features

Comments

@lblackstone
Copy link
Member

Each provider includes a Cancel() method that signals for the provider to stop ongoing work, save current state, and shut down. This method is not implemented in some providers, and is handled inconsistently where it is implemented.

Each provider should create a "session" context that shares a lifecycle with the provider, and then join this context to request-specific contexts that are included with each gRPC method. This will allow downstream code to have a consistent cancellation signal that can be used to terminate gracefully.

@lblackstone lblackstone added the kind/enhancement Improvements or new features label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

1 participant