Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile needs to be updated. #25

Open
MitchellGerdisch opened this issue May 6, 2022 · 1 comment
Open

Makefile needs to be updated. #25

MitchellGerdisch opened this issue May 6, 2022 · 1 comment
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@MitchellGerdisch
Copy link

What happened?

When using the Makefile in the boilerplate, there were issues creating the typescript provider.
Using the Makefile in the pulumi-service provider repo solved the problem.
So, the boilerplate Makefile should be updated accordingly.

Here's the diff:

@@ -54,10 +54,10 @@ nodejs_sdk::
 	$(WORKING_DIR)/bin/$(CODEGEN) -version=${VERSION} nodejs $(SCHEMA_FILE) $(CURDIR)
 	cd ${PACKDIR}/nodejs/ && \
 		yarn install && \
-		yarn run tsc
+		yarn run tsc && \
 		cp -R scripts/ bin && \
-	cp README.md LICENSE ${PACKDIR}/nodejs/package.json ${PACKDIR}/nodejs/yarn.lock ${PACKDIR}/nodejs/bin/
-	sed -i.bak 's/$${VERSION}/$(VERSION)/g' ${PACKDIR}/nodejs/bin/package.json
+		cp ../../README.md ../../LICENSE package.json yarn.lock ./bin/ && \
+		sed -i.bak -e 's/\$${VERSION}/$(VERSION)/g' ./bin/package.json

Steps to reproduce

Build a provider.

Expected Behavior

Make should work as expected.

Actual Behavior

Threw errors.
Had to adopt the Makefile from the pulumi-service provider.

Versions used

No response

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@MitchellGerdisch MitchellGerdisch added the kind/bug Some behavior is incorrect or out of spec label May 6, 2022
@AlgorithmEnigma
Copy link

This should have been closed by #27 right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

2 participants