Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow failure: Update dist files #1126

Closed
pulumi-bot opened this issue Mar 21, 2024 · 2 comments · Fixed by #1129
Closed

Workflow failure: Update dist files #1126

pulumi-bot opened this issue Mar 21, 2024 · 2 comments · Fixed by #1129
Assignees
Labels
kind/engineering Work that is not visible to an external user needs-triage Needs attention from the triage team p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed

Comments

@pulumi-bot
Copy link

Workflow Failure

Update dist files has failed. See the list of failures below:

@pulumi-bot pulumi-bot added kind/engineering Work that is not visible to an external user needs-triage Needs attention from the triage team p1 A bug severe enough to be the next item assigned to an engineer labels Mar 21, 2024
@Frassle
Copy link
Member

Frassle commented Mar 21, 2024

Looks like the progress dots PR triggered this.

@tgummerer
Copy link
Contributor

Seems like a retry has fixed this. No idea why the pre-commit hook would fail like this:

$ /home/runner/work/actions/actions/node_modules/.bin/lint-staged
/home/runner/work/actions/actions/node_modules/string-width/index.js:2
const stripAnsi = require('strip-ansi');
                  ^

Error [ERR_REQUIRE_ESM]: require() of ES Module /home/runner/work/actions/actions/node_modules/strip-ansi/index.js from /home/runner/work/actions/actions/node_modules/string-width/index.js not supported.
Instead change the require of /home/runner/work/actions/actions/node_modules/strip-ansi/index.js in /home/runner/work/actions/actions/node_modules/string-width/index.js to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (/home/runner/work/actions/actions/node_modules/string-width/index.js:2:19) {
  code: 'ERR_REQUIRE_ESM'
}

Node.js v20.11.1
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
husky - pre-commit hook exited with code 1 (error)
Error: Invalid status code: 1
    at ChildProcess.<anonymous> (/home/runner/work/_actions/stefanzweifel/git-auto-commit-action/v5/index.js:17:19)
    at ChildProcess.emit (node:events:514:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5) {
  code: 1
}
Error: Invalid status code: 1
    at ChildProcess.<anonymous> (/home/runner/work/_actions/stefanzweifel/git-auto-commit-action/v5/index.js:17:19)
    at ChildProcess.emit (node:events:514:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)

According to nkowaokwu/igbo_api#626 this should be fixed in husky versions newer than 7, and we have 8.0.3 as minimum.

Upgrading lint-staged also seems to have helped someone, so I'm gonna create a PR to do that: https://stackoverflow.com/questions/69960974/error-err-require-esm-husky-lint-staged-eslint-nodejs

@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user needs-triage Needs attention from the triage team p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants