[download-microservice] Auth All GitHub Requests #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now we have had no authentication on the
downloadmicroservice.With not enough consistent traffic to justify the setup and managing of keys.
But just recently we have been seeing consistent failures when users attempt to download rolling release versions and after #130 we can view the data returned from GitHub to discover we are actually running out of generic rate limit requests allotted. Which means we are having more than 60 requests for rolling releases per hour, which is insane in it's own right.
This PR adds the capabilities of the
downloadmicroservice to get credentials to authenticate to GitHub to ensure we don't run out of these requests.