Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move analytics.proto to its own repo and allow it to be a python dependency instead of checked in code #69

Open
bmbouter opened this issue Dec 5, 2022 · 3 comments

Comments

@bmbouter
Copy link
Member

bmbouter commented Dec 5, 2022

Right now the built analaytics.proto is built and then checked in to both this repo and pulpcore. It should instead be consumed as a python module that is received via PyPI.

To do this:

  1. The analytics.proto should be moved to its own repo.
  2. That repo should have CI that builds the protobuf python bindings
  3. Publish the build bindings to PyPI via a date-based string
@bmbouter
Copy link
Member Author

bmbouter commented Dec 5, 2022

One question that came up was how to do this in development.

One idea I had was to have a developer who is making a change to analytics.proto (in its own repo after this change) compile it locally and install it as an editable python package. So both this repo and pulpcore would consume it as a python dependency only a locally built one for dev purposes. Also having the new repo where analytics.proto lives have a Makefile command would allow the CI and local devs to build it easily.

@bmbouter
Copy link
Member Author

bmbouter commented Dec 5, 2022

@mdellweg here's an idea ^

@mdellweg
Copy link
Member

mdellweg commented Dec 6, 2022

sounds rather complicated... but we should try it that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants