Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate behavior of "More in this series" link #4595

Open
1 of 6 tasks
maxkadel opened this issue Nov 20, 2024 · 0 comments
Open
1 of 6 tasks

Investigate behavior of "More in this series" link #4595

maxkadel opened this issue Nov 20, 2024 · 0 comments
Labels
investigate Tickets related to work that needs investigation maintenance Ticket related to maintenance that needs to be done

Comments

@maxkadel
Copy link
Contributor

maxkadel commented Nov 20, 2024

What maintenance needs to be done?

Determine whether the change in the query dsl changed the behavior of the "More in this series" link

Level of urgency

  • High
  • Moderate
  • Low

Why is this maintenance needed?

Record: Wo de jia

I am expecting about 163 results that have the string of "you tong wen ku" in (series) title field

Instead the "More in this series" hyperlink for the Romanized titles is retrieving 462 results

Acceptance criteria

  • Determine whether the change in the query dsl changed the behavior of the "More in this series" link
  • If it has changed, make a ticket to restore previous behavior
  • If it has not changed, investigate what the correct behavior is, and if it is different from the current behavior, make tickets for desired behavior

Implementation notes, if any

Possibly an inadvertent change in #advanced_search_series_link when we switched to the JSON dsl? Possibly in this commit?

Should "clause[0][field]" be in_series rather than series_title?

@maxkadel maxkadel added investigate Tickets related to work that needs investigation maintenance Ticket related to maintenance that needs to be done labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigate Tickets related to work that needs investigation maintenance Ticket related to maintenance that needs to be done
Projects
None yet
Development

No branches or pull requests

1 participant