Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No setters for protected arguments #9

Open
danmichaelo opened this issue May 29, 2017 · 1 comment
Open

No setters for protected arguments #9

danmichaelo opened this issue May 29, 2017 · 1 comment

Comments

@danmichaelo
Copy link
Contributor

Seems to be no way to set lease_seconds, verify etc.??

@danmichaelo
Copy link
Contributor Author

Suggestion: Add an $options array to the constructor and extract the optional values from there:

public function __construct($hub_url, $callback_url, $credentials = false, $options = [])
    $this->lease_seconds = isset($options['lease_seconds']) ? $options['lease_seconds'] : null;
    ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant