Handle unencrypted message while getting messages with crypto #158
Conversation
subscription_manager.go
Outdated
| @@ -971,6 +971,10 @@ func parseCipherInterface(data interface{}, pnConf *Config, module crypto.Crypto | |||
| pnConf.Log.Println("v[pn_other]", v["pn_other"], v, msg) | |||
| decrypted, errDecryption := decryptString(module, msg) | |||
| if errDecryption != nil { | |||
| if strings.Contains(errDecryption.Error(), "decrypt error on decode") { | |||
| pnConf.Log.Println("Couldn't decode message. Asumming no encrypted message. Returning raw message...") | |||
| return msg, nil | |||
There was a problem hiding this comment.
Don't we want to inform user that there was a problem with message decoding?
I thought in this case we return error to the user?
There was a problem hiding this comment.
I'm afraid that our user will first check if there is any error and their program will fail in case of no encrypted message anyway what is pointless in this case. As I understood we should return Result type if it is possible in your implementation. Go is quite straightforward what means we cannot indicate the "something is not okay but we returning something anyway" in any way. :/
|
|
||
| assert.Nil(err) | ||
| assert.Equal("test", result) | ||
| } |
There was a problem hiding this comment.
I am not sure if it is worth adding it here but in Kotlin there are tests(one parameterized) that checks behaviour of the sdk when you try decrypt unencrypted message.
For this message: "this is unencrypted message"
This error is thrown:
PubNubException(errorMessage=Input length must be multiple of 16 when decrypting with padded cipher, pubnubError=PubNubError(name=CRYPTO_ERROR, code=135, message='Error while encrypting/decrypting message. Please contact support with error details.'), jso=null, statusCode=0, affectedCall=null)
For this message: “this is not encrypted message”
This error is thrown:
java.lang.IllegalArgumentException: bad base-64
For user they are handled the same way. The thing is that initially we didn't handle last example properly because this is not PubNub exception but java.lang.IllegalArgumentException
There was a problem hiding this comment.
Maybe there is currently lack of my knowladge how to prepare good test cases in Go. I wanted to have any test if the function behaves as desired.
Right now I'm trying to catch any base64 error that means it couldn't decode that - what indicates that message is not encrypted or encrypted in other way than using our SDKs.
|
@pubnub-release-bot release |
|
🚀 Release successfully completed 🚀 |
fix: Handle unencrypted message while getting messages with crypto
Handle unencrypted message while getting messages with crypto