New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the rsync filters file trying to reuse .distignore #1

Open

andergmartins opened this issue Aug 14, 2023 · 1 comment

Assignees

Contributor

andergmartins commented Aug 14, 2023

Right now we are using two files for filtering files in the build workflow:

.rsync-filters-pre-build: Used to speed up avoiding copying files that are not needed, or will be generated.
.rsync-filters-post-build: Used to remove all the files that should not be in the final package.

But WordPress uses .distignore for the same purpose of the second file. Can we reuse this instead of .rsync-filters-postbuild?

rsync -av --exclude-from=.distignore --dry-run /path/to/source/ /path/to/destination/

The text was updated successfully, but these errors were encountered:

andergmartins self-assigned this

Contributor Author

andergmartins commented Aug 14, 2023

Maybe we will have 3 filters?

.gitattributes: Used by composer
.buildignore: Used by our build script (pre-build filter)
.distignore: Used by WP and by our build script (pro-build filter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment