-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for routes to protect them #736
Comments
The format for a routes test is: test "test user_sessions create route" do
assert_routing({ path: '/user_sessions', method: :post }, { controller: 'user_sessions', action: 'create' })
end |
Ohh this is a great idea! @jywarren Will open some ftos based off this and possibly an issue in plots2 as well to get contributors to this repo ✌️ |
Hi! I've completed a FTO issue - I'm still pretty new to contributing to open source but I'm wondering if there is anything I can do to help with this issue? Is the list complete, or can I help to create some more FTO issues? Thank you! |
Hey @mskalisz Feel free to open more FTO issues based on this 💯 . I usually look out for the routes that are recently added/modified for the tests? |
Based on this PR: publiclab/plots2#10242
we can protect routes; a lot of routes were broken in a recent upgrade: https://github.com/publiclab/spectral-workbench/search?q=route&type=issues
Let's make a big list of them - you can see recently fixed ones in the "blame" view of https://github.com/publiclab/spectral-workbench/blame/main/config/routes.rb - and create first-timers-only issues to add route tests for them! Since they're tests, they'll be really easy to review and approve.
The text was updated successfully, but these errors were encountered: