-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration With Plots2 #60
Comments
Hi Isha! Just copying in the note from the open call on this:
See how this code pattern-matches the |
So let's implement a second version like |
and once we feel good about it we can replace the original! |
Oh alright, let me have a look and understand these ones! Thank you! |
I am not very sure on what exactly we are supposed to do here? Could you please elaborate more on this? |
@jywarren I am happy to tell you that I have published the first version of simple-data-grapher on npm and will be updating it soon to remove redundant code and I am about to begin with the process of integrating it with plots2 very soon. |
@jywarren I have done the basic integration with plots2!! |
oh wow, cool - can you share a PR? How does it work?
…On Mon, Jul 1, 2019 at 11:08 AM Isha Gupta ***@***.***> wrote:
@jywarren <https://github.com/jywarren> I am happy to tell you that I
have published the first version of simple-data-grapher on npm and will be
updating it soon to remove redundant code and I am about to begin with the
process of integrating it with plots2 very soon.
https://www.npmjs.com/package/simple-data-grapher
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#60?email_source=notifications&email_token=AAAF6J47A7KHKSFVZ5FNI3TP5IMVRA5CNFSM4H3ORHKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY6NVYQ#issuecomment-507304674>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6JZ6XFH6KP5F6P7P3ZTP5IMVRANCNFSM4H3ORHKA>
.
|
Yes definitely, I would be creating one in plots2 and share the link here! |
This is a simpler example we mentioned on the call! https://github.com/publiclab/plots2/blob/master/app/views/editor/rich.html.erb#L17-L18 |
Here is where we're inserting the Ruby values into the constructor of the Editor library! |
Here's the PR @jywarren publiclab/plots2#5993 |
This is the next thing we need to do.
Once this is integrated with the main site like PL editor, the functionality will remain the same, but we need to understand how this is to be done.
I am not very sure about how to begin with it, and it would be great if I could get some guidance here for the same.
Once we have integrated this, we have to implement (some or all) of the following features:
Displaying per-user data
Publishing generated charts as a
Research Note
Plot charts from previously uploaded files.
Detailed explanations can be found at https://publiclab.org/notes/IshaGupta18/03-04-2019/gsoc-proposal-sensor-data-upload-and-display-library
@jywarren @namangupta01 @gauravano @rexagod @IgorWilbert it would be great if you all could start me up with this one. Thanks a ton!
The text was updated successfully, but these errors were encountered: