"Show more"/ "show less" links not working on inline power-tags

[PeculiarE]

Please describe the problem (or idea)

On the Outreachy summer 2022 call-for-proposals page on PublicLab, we have just 24 proposals visible there.

But there are about 10 or so proposals of people that submitted earlier (of which I'm included) that can no longer be seen on the page.

However, when I clicked on the outreachy-2022 tag, I was redirected to a page showing the complete list of 34 Outreachy proposals (24 on page 1, and 10 on page 2). But on the actual call-for-proposals page, we can only see the latest 24 proposals and there is no pagination to show that there are more proposals and fetch them.

Please see the screen recording below:

proposals-page-demo.mp4

As seen in the demo above, a Show More text appears under the embedded container on Chrome (this text is not visible on Safari) but clicking it does nothing to fetch the other proposals.

Please show us where to look

https://publiclab.org/notes/cess/04-04-2022/call-for-proposals-outreachy-summer-2022

https://publiclab.org/tag/outreachy-2022

What's your PublicLab.org username?

perhisohwode

Browser, version, and operating system

Google Chrome Version 100.0.4896.60 (Official Build) (arm64), MacOS Big Sur version 11.4

[PeculiarE]

Hi @jywarren, @TildaDares, @cesswairimu, could we please take a look at this issue.

I've been looking at the codebase and I believe there's a limit of 24 when fetching nodes and that might be responsible for the 'disappearance' of earlier proposals.

A possible fix for this is to display a button or text like the current 'Show More' visible on Chrome where readers can see that there are more proposals and click on it to fetch these extra nodes, especially for Outreachy and GSOC rounds with lots of applicants like the just concluded one.

I do have a bit of worry: Does the current state of things in any way affect the chances of those who submitted their proposals earlier? I'm assuming proposal review happens on the call-for-proposals page, and as there is no indication on the page that there are earlier proposals for that round and no way to fetch them, I'm slightly worried that proposals submitted earlier might not get a final review even when they've been updated by applicants.

Thank you!

[cesswairimu]

Hi @PeculiarE, good catch, you are right seems the Show More button is not working. I do not think it affects the state of things I believe we reviewed all of the proposals posted early. thanks

[jywarren]

Hello @PeculiarE - yes, thank you for this catch, i had noticed it as well, and it hadn't come up before because we had never had this many proposals. Luckily we saw it early enough and were able to review all proposals -- I cross referenced carefully with all the proposals posted on Outreachy.org.

But it's a visibility issue still -- I suggest we add a count to the "Show more" link - maybe changing it to "View all 123" or "View all 123 in 'tagname'" ?

That way we let people know the total as well, and we don't just skim past the "Show More" link. What do you think?

[PeculiarE]

Thank you for the reassurances @jywarren and @cesswairimu. I really appreciate ❤️

@jywarren, what you're suggesting does sound interesting, but I have a couple of points I'll love clarified:

1. Using the call-for-proposals as an example, so we will have a 'View all 34 proposals in outreachy-22' link that when clicked on redirects users to the outreachy-2022 tag page?

2. This question might sound silly but a note most times has several tags attached to it. So won't it be tricky trying to figure out which of the tags has all the related notes? Or is there an easier way to achieve this?

3. Will the visibility of this link be optional based on the node count? For example, if there are just 9 proposals, will this link still be visible?

4. I mentioned in the issue description that the 'Show More' text doesn't show across all browsers (Safari, for one). I'm yet to figure out why that's the case. Do you have any idea why that is?

Thank you!

[ebarry]

This is a very worthwhile investigation! Thanks for puzzling through this

[jywarren]

• This question might sound silly but a note most times has several tags attached to it. So won't it be tricky trying to figure out which of the tags has all the related notes? Or is there an easier way to achieve this?

Just circling back to answer here -- so, although notes have multiple tags, the inline display is driven from a single tag, so we can use that. That is, you create an inline grid by inserting the string [notes:water-quality] for example, so we can use the tag that is specified. (https://publiclab.org/wiki/power-tags#Inline+power+tags)

Will the visibility of this link be optional based on the node count? For example, if there are just 9 proposals, will this link still be visible? Yes, i think we should show it if there are more results than we are currently showing in the grid. Make sense?

I mentioned in the issue description that the 'Show More' text doesn't show across all browsers (Safari, for one). I'm yet to figure out why that's the case. Do you have any idea why that is?

Is there a possibility it's cut off by the element having hidden content you have to scroll to see? Or, maybe there is a safari-specific bug in JS somehow affecting the display?