-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI update: making people's boxes equal in height #11052
Comments
Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help. |
Hi @void-ness, this looks really great. Can I see a screenshot of a card with longer tags and one without? Something like this: |
Hey! Glad to know that. Here's the requested screenshot. (one with longer tags on one card and none on other) (other examples for reference) apart from that, I would like to add on if the user names can also be aligned in the same line it will give a better user experience. This misalignment is only in the case where the number of badges are not equal for two adjacent user cards. Here's an example showing the bad formatting due to increased height. For this, one solution is to update the flexbox alignment values accordingly. Like updating the align items attribute for the flex box can be a good start. |
@void-ness This looks really great. You can go ahead and open a PR for it. Thanks!! |
Hey! is this issue open? and if yes, can I contribute to it? Please let me know. :) |
Thank you so much for the go ahead. I am more than happy to work on it. I would like to mention one more issue related to this. In the people page, each card of a user can show at most 3 badges in the current GUI. Here attaching an image for reference.
Therefore if a viewer intends to view what all badges a person has, he needs to click on a user's card which then opens up a new webpage showing more details about the user. I have a suggestion regarding the same. A graphical object can be added in the UI, hovering over which will popup the details about the other badges of the user. Here attaching a screen snap for an idea. Something on the lines of above can be worked out. With this I have noticed, through this open issue, a collection of sub issues have been raised, and it will be difficult to address them in a single PR. keeping that in mind, I have included these issues to be a part of my GsoC proposal. You can find it over here. I would love to know your thoughts about the same. Rest assured I will be more than happy to work on the above mentioned issues whole heartedly. |
Hey, Can I work on this issue? |
Hi @nawed2611, please go ahead! Feel free to reach out if you need help. Thanks! |
Thanks for the quick reply! |
Hi @TildaDares 👋🏼 |
Hi @NPDebs, please go ahead. Thank you! |
Thank you very much, @TildaDares. I'll revert to you soon. |
Hello @TildaDares can I go ahead to contribute to this issue? THANKS |
Hi @FrancoFrancis, @NPDebs is already working on this. Maybe you could ask them if they need assistance. |
ok thanks |
@NPDebs do you need some help? |
Hi @FrancoFrancis 👋🏼 I've been battling lots of errors trying to get setup (using gitpod). Here are some screenshots to help put things in perspective... |
Thank you... |
i think the community is the best place to have this conversation so other people can learn or help out too. |
Hello community members. While navigating through the Publiclab.org website I stumbled upon the people's page. The page is very well drafted. however the div containing each users details are visually not equal in height due to badges assigned to each user.
To give you all a better idea, please find attached a photo explanation of the above issue.
An inspection of the above shows that the div are of equal size. but the cards inside it are not utilizing 100% height of their div. proof attached below
This can be fixed by making changes in the stylesheet file. For example I would like to propose we can specify height attribute to "peoplecard" class and its value can be set to 100%. I have attached a reference photo to show how the website will look after making the changes. for the sake of eg, I have specified height attribute to "card" class. In future this can be avoided to prevent unwanted changes across the overall website as class "card" seems to be more general.
I would suggest doing this change to bring about a touch up of symmetricity on the website. Do let me know your thoughts on the same and suggest changes if required. waiting for your feedback. Thank you 😄
The text was updated successfully, but these errors were encountered: