-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and modularize processSection.js
#71
Labels
Comments
11 tasks
avishon
added a commit
to avishon/inline-markdown-editor
that referenced
this issue
Oct 7, 2019
7 tasks
Hello, @rexagod I would like to work on this issue can you please assign this to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @jywarren to get it labelled. Or, if this is not your first time, try to solve it yourself!
To complete this PR, we want you to convert
processSection.js
into smaller modules and then make use of those inside it. We'd also like if you could, along the way make some refactors such as reducing the numbers of params passed to a function by encapsulating them into an objectwith similar props and accessing it accordingly. A good place to start doing this is
inline-markdown-editor/src/processSection.js
Lines 64 to 65 in c634253
Also, please don't hesitate to ping me, or @jywarren to help you if you're stuck anywhere!
Thanks! 🎉
The text was updated successfully, but these errors were encountered: