-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[suggestion] Add Dark theme #851
Comments
@publiclab/mentors @jywarren @tech4GT @SidharthBansal What do you think about this I have also opened the same issue in community toolbox. Please review me. |
@avsingh999 can you please provide a mockup for this? |
I guess we can add it as a option. So that the user chooses the one(dark mode or normal) |
That is good. But actually implementing dark mode will be difficult since we use bootstrap as our frontend framework. Will we have to override almost all the bootstrap classes ? |
@harshkhandeparkar Yes, It would be difficult. Let's see for other reviews. |
I think there are bootstrap themes... Maybe there's a dark theme?
…On Wed, Mar 13, 2019, 7:28 AM Avkaran Singh ***@***.***> wrote:
@harshkhandeparkar <https://github.com/HarshKhandeparkar> Yes, It would
be difficult. Let's see for other reviews.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#851 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ5UF7_WDdqfZxbsKNoTgXsZfpv1Sks5vWOCqgaJpZM4brDDR>
.
|
@jywarren maybe But I search and I found it's may be helpful https://bootswatch.com/darkly/ for this. |
:-) cool!!!! awesome!
…On Mon, Apr 8, 2019 at 2:35 PM Harsh Khandeparkar ***@***.***> wrote:
Hi everyone I found some cool bootswatch dark themes:
- cyborg <https://bootswatch.com/cyborg/>
- darkly <https://bootswatch.com/darkly/>
- lux <https://bootswatch.com/lux/> (semi dark)
- slate <https://bootswatch.com/slate/> (kind of like YouTube, my
favourite)
cc @jywarren <https://github.com/jywarren> @publiclab/is-reviewers
<https://github.com/orgs/publiclab/teams/is-reviewers> @avsingh999
<https://github.com/avsingh999>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#851 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ54ZyCFXc-ZPfaiexKXhur43g8Dyks5ve4vSgaJpZM4brDDR>
.
|
@jywarren what is your thought on making the whole UI to react?? |
:-) I think it's a positive direction -- but I really want to stabilize the
existing system as much as possible so that some real-world use cases can
be launched, before taking on a major UI refactoring. I'll write back soon
to your question about UI tests, but I think that has to be part of it too!
Thank you!!!
…On Mon, Apr 8, 2019 at 2:55 PM Harshith pabbati ***@***.***> wrote:
@jywarren <https://github.com/jywarren> what is your thought on making
the whole UI to react??
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#851 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ67mIlLZllpcPhZkkeHGiaEHEhYZks5ve5CTgaJpZM4brDDR>
.
|
@harshkhandeparkar i have solved this issue so, can i open a PR for it ? |
Go for it! |
Ok. And thank-you 😊 |
Please describe the problem (or idea)
I have an idea Dark theme for image-sequencer.It would be better UI. I have also oppend same issue for community toolbox publiclab/community-toolbox#155.
Please show us where to look
http://sequencer.publiclab.org...
What's your PublicLab.org username?
singhav
Browser, version, and operating system
Thank you!
Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.
To learn how to write really great issues, which increases the chances they'll be resolved, see:
https://publiclab.org/wiki/developers#Contributing+for+non-coders
The text was updated successfully, but these errors were encountered: