Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] Add Dark theme #851

Open
avsingh999 opened this issue Mar 12, 2019 · 14 comments · May be fixed by #1824
Open

[suggestion] Add Dark theme #851

avsingh999 opened this issue Mar 12, 2019 · 14 comments · May be fixed by #1824

Comments

@avsingh999
Copy link
Member

Please describe the problem (or idea)

I have an idea Dark theme for image-sequencer.It would be better UI. I have also oppend same issue for community toolbox publiclab/community-toolbox#155.

What happened just before the problem occurred? Or what problem could this idea solve?

What did you expect to see that you didn't?

Please show us where to look

http://sequencer.publiclab.org...

What's your PublicLab.org username?

singhav

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@avsingh999
Copy link
Member Author

@publiclab/mentors @jywarren @tech4GT @SidharthBansal What do you think about this I have also opened the same issue in community toolbox. Please review me.
thanks : )

@Divy123
Copy link
Member

Divy123 commented Mar 12, 2019

@avsingh999 can you please provide a mockup for this?

@Divy123 Divy123 added the UI label Mar 12, 2019
@harshithpabbati
Copy link

I guess we can add it as a option. So that the user chooses the one(dark mode or normal)

@harshkhandeparkar
Copy link
Member

I guess we can add it as a option. So that the user chooses the one(dark mode or normal)

That is good. But actually implementing dark mode will be difficult since we use bootstrap as our frontend framework. Will we have to override almost all the bootstrap classes ?

@avsingh999
Copy link
Member Author

@harshkhandeparkar Yes, It would be difficult. Let's see for other reviews.

@jywarren
Copy link
Member

jywarren commented Mar 14, 2019 via email

@avsingh999
Copy link
Member Author

@jywarren maybe But I search and I found it's may be helpful https://bootswatch.com/darkly/ for this.
thanks : )

@harshkhandeparkar
Copy link
Member

Hi everyone I found some cool bootswatch dark themes:

cc @jywarren @publiclab/is-reviewers @avsingh999

@jywarren
Copy link
Member

jywarren commented Apr 8, 2019 via email

@harshithpabbati
Copy link

@jywarren what is your thought on making the whole UI to react??

@jywarren
Copy link
Member

jywarren commented Apr 8, 2019 via email

@vivek-30
Copy link

@harshkhandeparkar i have solved this issue so, can i open a PR for it ?

@harshkhandeparkar
Copy link
Member

Go for it!

@vivek-30
Copy link

Ok. And thank-you 😊

@vivek-30 vivek-30 linked a pull request Feb 26, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants