Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot and Travis #4

Open
harshkhandeparkar opened this issue Apr 19, 2019 · 8 comments
Open

Dependabot and Travis #4

harshkhandeparkar opened this issue Apr 19, 2019 · 8 comments

Comments

@harshkhandeparkar
Copy link
Member

We could:

  • Add tests
  • More dependencies like jQuery, grunt, Materialize are going to be added soon so should we add dependabot as well
  • Finally travis
@harshkhandeparkar
Copy link
Member Author

@jywarren I just wanted to tell you that I (and other is-reviewers mostly) have access to editing dependabot settings.

@vibhorgupta-gh
Copy link
Collaborator

Nice additions. Let's make this happen after the barebones UI

@harshkhandeparkar
Copy link
Member Author

Yes. 🚀

@harshkhandeparkar
Copy link
Member Author

@jywarren I have access to publiclab's dependabot account (IDK why). Should I add it to this repo?

@harshkhandeparkar
Copy link
Member Author

@jywarren I actually could edit the settings and dependabot added new commits. This might be insecure. Please have a look at it. I don't think I should have been able to add dependabot to this repo.

@jywarren
Copy link
Member

@Divy123 @harshkhandeparkar is this possible now with the basic demo running? Can we add Jasmine tests and confirm that it's outputting the correct ratio?

@jywarren
Copy link
Member

@harshkhandeparkar
Copy link
Member Author

harshkhandeparkar commented Aug 20, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants