Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cyclic dependencies #162

Open
shanev opened this issue Nov 3, 2022 · 0 comments
Open

Fix cyclic dependencies #162

shanev opened this issue Nov 3, 2022 · 0 comments

Comments

@shanev
Copy link
Member

shanev commented Nov 3, 2022

Marketplace, name minter, and sg721-name are too intertwined.

Ideas:

  • Use types in packages instead of concrete contract types
  • Use hooks instead of directly linking contracts
@shanev shanev mentioned this issue Nov 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shanev