Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: internal polishing #50

Closed
5 of 7 tasks
tipogi opened this issue Aug 3, 2024 · 2 comments
Closed
5 of 7 tasks

Fix: internal polishing #50

tipogi opened this issue Aug 3, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request 🔮 nexus

Comments

@tipogi
Copy link
Collaborator

tipogi commented Aug 3, 2024

As we develop our project, we've identified some internal improvements that need our attention alongside new feature development. These aren't visible to end-users but are crucial for the project's long-term success:

  • Split up the tests inside their respective model files, instead of having a single file to define all integration tests (/tests)
  • Create an environment file for database benchmarks. This will allow us to make different queries instead of having them hard-coded (/benches)
  • Map graph database Row data type to Rust structs. This converts the raw row data into a strongly-typed Rust structure
  • For new structs that should have default values, implement the Default trait instead of manually defining default values
  • Implement unique constraints and indexes in the graph database schema to enforce data integrity and prevent duplicate entries
  • Implement event validation pipeline: verify data integrity and format and transform data (e.g., string to pubkey_user_id, string to Crockfordbase32 encoding). Filter valid events before processing to ensure consistent and properly formatted data
  • ...
@SHAcollision
Copy link
Collaborator

@tipogi some of these items are already completed. Maybe almost all of them are completed or partially done. If anything left, we should create an issue for it and close here. What do you think?

@SHAcollision SHAcollision changed the title Internal Polishing Fix: internal polishing Nov 18, 2024
@SHAcollision
Copy link
Collaborator

Closing, opened #202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🔮 nexus
Projects
None yet
Development

No branches or pull requests

2 participants