Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better detection of protocol #55

Closed
Nuhvi opened this issue Nov 5, 2024 · 1 comment
Closed

Better detection of protocol #55

Nuhvi opened this issue Nov 5, 2024 · 1 comment
Assignees
@Nuhvi

Comments

@Nuhvi
Copy link
Collaborator

Nuhvi commented Nov 5, 2024

Currently we use is_secure(host) method to decide whether or not to set the secure property on cookies.

Instead we have another better option:

  1. use axum_server with rustls and certificates, and add a layer to the https server to add Protocol extractor.
  2. behind reverse proxy, use x-forwarded-proto header.
@Nuhvi Nuhvi self-assigned this Nov 5, 2024
@Nuhvi
Copy link
Collaborator Author

Nuhvi commented Dec 23, 2024

We are only using non secure for localhost environment.

@Nuhvi Nuhvi closed this as completed Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nuhvi Nuhvi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Nuhvi