Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubkyClient: Re-send HTTP requests after Pkarr cache update. #29

Open
Nuhvi opened this issue Sep 3, 2024 · 1 comment
Open

PubkyClient: Re-send HTTP requests after Pkarr cache update. #29

Nuhvi opened this issue Sep 3, 2024 · 1 comment
Assignees
Labels
http All things related to making HTTP requests over Pkarr robust and reliable pkarr Pkarr related issues

Comments

@Nuhvi
Copy link
Collaborator

Nuhvi commented Sep 3, 2024

By default, Pkarr resolves the first response, which could be an outdated packet, either normally or maliciously sent by a peer trying to disrupt resolution of a given address. But in the background, more recent packets should be resolved, so after a failing HTTP request (with appropriate codes) the PubkyClient should check if the Pkarr cache has relevant updates that points to a different servers (Endpoint), and if so, retry calling that instead.

There should also be a limit for that to avoid the very.. very unlikely loop if someone keeps publishing new packets!

@Nuhvi Nuhvi added the pkarr Pkarr related issues label Sep 3, 2024
@Nuhvi Nuhvi self-assigned this Sep 3, 2024
@Nuhvi Nuhvi added http All things related to making HTTP requests over Pkarr robust and reliable enhancement New feature or request and removed enhancement New feature or request labels Sep 3, 2024
@Nuhvi
Copy link
Collaborator Author

Nuhvi commented Dec 23, 2024

We should instead use Endpoints from Pkarr, and retries using Reqwest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http All things related to making HTTP requests over Pkarr robust and reliable pkarr Pkarr related issues
Projects
None yet
Development

No branches or pull requests

1 participant