Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider storing historical data #42

Open
decentralgabe opened this issue Jan 26, 2024 · 4 comments
Open

Consider storing historical data #42

decentralgabe opened this issue Jan 26, 2024 · 4 comments

Comments

@decentralgabe
Copy link

Add a query parameter to the GET API to query by sequence number.

Allow relays to optionally store historical data, which may be useful.

@Nuhvi
Copy link
Collaborator

Nuhvi commented Feb 3, 2024

@decentralgabe sorry missed this, have you implemented this somewhere and suggesting to add it to the relay API design?

I don't have a strong opinion against it except for managing expectations. Would like to see your implementation if any.

@Nuhvi
Copy link
Collaborator

Nuhvi commented Feb 3, 2024

I wouldn't want to promise any persistence or even a large cache. Relays were meant for helping browsers not much more.

@decentralgabe
Copy link
Author

have you implemented this somewhere and suggesting to add it to the relay API design

impl is in progress, but it is in our spec under Historical Resolution

we pretty much return a sorted list of seq numbers when you do a GET for an identifier, and then you can add a query param for a specific seq number

I wouldn't want to promise any persistence or even a large cache. Relays were meant for helping browsers not much more.

Agree, don't think it should be a requirement but optional for relays that wish to do this.

@Nuhvi
Copy link
Collaborator

Nuhvi commented Feb 6, 2024

@decentralgabe storing historical data is a good idea for many use cases and could even serve as soft key rotation mechanism if enough watch towers are around. But I want to keep an eye first on your efforts for rate limiting and see if it works, scales, and endures better than ION.

Keeping this issue open for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants