Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ComradeBase gpu compatible #37

Merged
merged 6 commits into from
Aug 25, 2024
Merged

Make ComradeBase gpu compatible #37

merged 6 commits into from
Aug 25, 2024

Conversation

ptiede
Copy link
Owner

@ptiede ptiede commented Aug 22, 2024

No description provided.

@ptiede ptiede changed the title Makie ComradeBase gpu compatible Make ComradeBase gpu compatible Aug 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 65.82278% with 27 lines in your changes missing coverage. Please review.

Project coverage is 84.60%. Comparing base (48798ff) to head (40496cc).

Files Patch % Lines
ext/ComradeBaseKernelAbstractionsExt.jl 0.00% 13 Missing ⚠️
ext/ComradeBaseAdaptExt.jl 0.00% 6 Missing ⚠️
src/images/dim_image.jl 50.00% 3 Missing ⚠️
src/unstructured/broadcast.jl 81.25% 3 Missing ⚠️
src/unstructured/domain.jl 94.73% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   87.77%   84.60%   -3.18%     
==========================================
  Files          10       14       +4     
  Lines         499      526      +27     
==========================================
+ Hits          438      445       +7     
- Misses         61       81      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptiede
Copy link
Owner Author

ptiede commented Aug 24, 2024

This won't be merged until rafaqz/DimensionalData.jl#780 is ready

ext/ComradeBaseAdaptExt.jl Outdated Show resolved Hide resolved
ext/ComradeBaseAdaptExt.jl Outdated Show resolved Hide resolved
@ptiede ptiede merged commit e65308d into main Aug 25, 2024
3 checks passed
@ptiede ptiede deleted the ptiede-gpuexec branch August 25, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants